elireth123
Enthusiast
Greetings.
I've been experimenting with TrinityCore in 4.3.4 (with Eluna) and tried to place GOMove on it. Here are the updated files:
GOMove.cpp
https://app.box.com/s/q8j5tpzwhhzdgr3zje8q
Addon
https://app.box.com/s/75296q91icyyom08mvwb
All the credit is for Kretol
source:
http://www.trinitycore.org/f/topic/7038-gomove-trinitycore-with-ui-addon/page-4
My problem starts in the configuration of the source, I modify GameObject.cpp and ObjectGuid.h
I noticed that some things have changed in terms Syntax (or so I think).
These are the errors I get from CMake on the "Make" process:
This is an extract of the original GameObject.cpp code:
This is the change that must be applied:
This is an extract of the original ObjectGuid.h code:
This is the change that must be applied:
Those are the two places where the error occurs
Sorry if this is not going in this section or elsewhere, if so I apologize. The idea is to update the addon and script to the latest update of TrinityCore Cataclyms with eLuna core (from the repo here).
Thanks for the help, probably just about changes in syntax but I'm so noob maybe I can not see at all. Anyway I think it can be helpful for all this update, it is a tool highly prized by some.
I've been experimenting with TrinityCore in 4.3.4 (with Eluna) and tried to place GOMove on it. Here are the updated files:
GOMove.cpp
https://app.box.com/s/q8j5tpzwhhzdgr3zje8q
Addon
https://app.box.com/s/75296q91icyyom08mvwb
All the credit is for Kretol
source:
http://www.trinitycore.org/f/topic/7038-gomove-trinitycore-with-ui-addon/page-4
My problem starts in the configuration of the source, I modify GameObject.cpp and ObjectGuid.h
I noticed that some things have changed in terms Syntax (or so I think).
These are the errors I get from CMake on the "Make" process:
Code:
In file included from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/World/World.h:28:0,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/collision/Management/MMapManager.cpp:21:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h: In constructor ‘ObjectGuid::ObjectGuid(HighGuid, uint32, uint32)’:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h:93:235: error: expected ‘)’ before ‘;’ token
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) { _data._guid(int32(hi) > 70000 || counter ? uint64(counter) | (uint64(entry) << 32) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
^
In file included from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectDefines.h:23:0,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/Object.h:25,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Movement/MotionMaster.h:25,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Unit/Unit.h:27,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/GameObject/GameObject.h:24,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/collision/Models/GameObjectModel.cpp:26:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h: In constructor ‘ObjectGuid::ObjectGuid(HighGuid, uint32, uint32)’:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h:93:235: error: expected ‘)’ before ‘;’ token
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) { _data._guid(int32(hi) > 70000 || counter ? uint64(counter) | (uint64(entry) << 32) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
^
In file included from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectDefines.h:23:0,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/Object.h:25,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Maps/MapManager.h:22,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/PrecompiledHeaders/gamePCH.h:4,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/PrecompiledHeaders/gamePCH.cpp:1:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h: In constructor ‘ObjectGuid::ObjectGuid(HighGuid, uint32, uint32)’:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h:93:235: error: expected ‘)’ before ‘;’ token
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) { _data._guid(int32(hi) > 70000 || counter ? uint64(counter) | (uint64(entry) << 32) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
^
make[2]: *** [src/server/collision/CMakeFiles/collision.dir/Management/MMapManager.cpp.o] Error 1
make[2]: *** Se espera a que terminen otras tareas....
In file included from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/World/World.h:28:0,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/Scripting/ScriptMgr.h:27,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/scripts/PrecompiledHeaders/ScriptPCH.h:8,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/scripts/PrecompiledHeaders/ScriptPCH.cpp:5:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h: In constructor ‘ObjectGuid::ObjectGuid(HighGuid, uint32, uint32)’:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h:93:235: error: expected ‘)’ before ‘;’ token
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) { _data._guid(int32(hi) > 70000 || counter ? uint64(counter) | (uint64(entry) << 32) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
^
In file included from /home/desktop/Escritorio/elunacore/Eluna/src/server/game/World/World.h:28:0,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/worldserver/PrecompiledHeaders/worldPCH.h:2,
from /home/desktop/Escritorio/elunacore/Eluna/src/server/worldserver/PrecompiledHeaders/worldPCH.cpp:1:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h: In constructor ‘ObjectGuid::ObjectGuid(HighGuid, uint32, uint32)’:
/home/desktop/Escritorio/elunacore/Eluna/src/server/game/Entities/Object/ObjectGuid.h:93:235: error: expected ‘)’ before ‘;’ token
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) { _data._guid(int32(hi) > 70000 || counter ? uint64(counter) | (uint64(entry) << 32) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
^
make[2]: *** [src/server/collision/CMakeFiles/collision.dir/Models/GameObjectModel.cpp.o] Error 1
make[1]: *** [src/server/collision/CMakeFiles/collision.dir/all] Error 2
make[1]: *** Se espera a que terminen otras tareas....
make[2]: *** [src/server/worldserver/CMakeFiles/worldPCH.cpp_dephelp.dir/PrecompiledHeaders/worldPCH.cpp.o] Error 1
make[1]: *** [src/server/worldserver/CMakeFiles/worldPCH.cpp_dephelp.dir/all] Error 2
make[2]: *** [src/server/game/CMakeFiles/gamePCH.cpp_dephelp.dir/PrecompiledHeaders/gamePCH.cpp.o] Error 1
make[1]: *** [src/server/game/CMakeFiles/gamePCH.cpp_dephelp.dir/all] Error 2
make[2]: *** [src/server/scripts/CMakeFiles/ScriptPCH.cpp_dephelp.dir/PrecompiledHeaders/ScriptPCH.cpp.o] Error 1
make[1]: *** [src/server/scripts/CMakeFiles/ScriptPCH.cpp_dephelp.dir/all] Error 2
make: *** [all] Error 2
This is an extract of the original GameObject.cpp code:
Code:
Object::_Create(guidlow, goinfo->entry, HIGHGUID_GAMEOBJECT);
m_goInfo = goinfo;
This is the change that must be applied:
Code:
static uint32 GOMoveID = 70000;
Object::_Create(guidlow, goinfo->entry, guidlow == 0 ? HighGuid(++GOMoveID) : HIGHGUID_GAMEOBJECT);
This is an extract of the original ObjectGuid.h code:
Code:
static ObjectGuid const Empty;
ObjectGuid() { _data._guid = UI64LIT(0); }
explicit ObjectGuid(uint64 guid) { _data._guid = guid; }
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) { _data._guid = counter ? uint64(counter) | (uint64(entry) << 32) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
ObjectGuid(HighGuid hi, uint32 counter) { _data._guid = counter ? uint64(counter) | (uint64(hi) << ((hi == HIGHGUID_CORPSE || hi == HIGHGUID_AREATRIGGER) ? 48 : 52)) : 0; }
This is the change that must be applied:
Code:
ObjectGuid(HighGuid hi, uint32 entry, uint32 counter) : _guid(int32(hi) > 70000 || counter ? uint64(counter) | (uint64(entry) << 24) | (uint64(hi) << 48) : 0) { }
Those are the two places where the error occurs
Sorry if this is not going in this section or elsewhere, if so I apologize. The idea is to update the addon and script to the latest update of TrinityCore Cataclyms with eLuna core (from the repo here).
Thanks for the help, probably just about changes in syntax but I'm so noob maybe I can not see at all. Anyway I think it can be helpful for all this update, it is a tool highly prized by some.