• This is a read only backup of the old Emudevs forum. If you want to have anything removed, please message me on Discord: KittyKaev

Help Updating Scripts Custom Scripts to Latest Rev

Status
Not open for further replies.
Demonid

Demonid

Enthusiast
Hello, i just updated my core for the first time since 10 months and im getting a lot of errors on my old scripts, for example this one:

Code: 
#include "ScriptPCH.h"
#include "Config.h"

#define SPELL_MASK_CLASS        1
#define SPELL_MASK_RIDING       2
#define SPELL_MASK_MOUNT        4
#define SPELL_MASK_WEAPON       8
#define SPELL_MASK_PROFESSION   16
#define SPELL_MASK_DUAL_SPEC    32

struct LearnSpellForClassInfo
{
    uint32  SpellId;
    uint8  SpellMask;
    uint32  RequiredClassMask;
    uint32  RequiredRaceMask;
    uint8   RequiredLevel;
    uint32  RequiredSpellId;
    uint16  RequiredSkillId;
    uint16  RequiredSkillValue;
};

bool AutoLearnEnable = false;
uint8 OnLevelSpellMask = 0;
uint8 OnSkillSpellMask = 0;
uint8 OnLoginSpellMask = 0;
uint8 OnCreateSpellMask = 0;
std::vector<LearnSpellForClassInfo> LearnSpellForClass;

class Mod_AutoLearn_WorldScript : public WorldScript
{
public:
    Mod_AutoLearn_WorldScript() : WorldScript("Mod_AutoLearn_WorldScript") { }

    // Called after the world configuration is (re)loaded.
    void OnConfigLoad(bool /*reload*/)
    {
        AutoLearnEnable = sConfigMgr->GetBoolDefault("AutoLearn.Enable", false);
        if (!AutoLearnEnable)
            return;

        uint8 loadSpellMask = OnLevelSpellMask | OnSkillSpellMask;
        OnLevelSpellMask = 0;
        OnSkillSpellMask = 0;
        OnLoginSpellMask = 0;
        OnCreateSpellMask = 0;

        if (sConfigMgr->GetBoolDefault("AutoLearn.Check.Level", false))
        {
            if (sConfigMgr->GetBoolDefault("AutoLearn.SpellClass", false))
                OnLevelSpellMask += SPELL_MASK_CLASS;
            if (sConfigMgr->GetBoolDefault("AutoLearn.SpellRiding", false))
                OnLevelSpellMask += SPELL_MASK_RIDING;
            if (sConfigMgr->GetBoolDefault("AutoLearn.SpellMount", false))
                OnLevelSpellMask += SPELL_MASK_MOUNT;
            if (sConfigMgr->GetBoolDefault("AutoLearn.SpellWeapon", false))
                OnLevelSpellMask += SPELL_MASK_WEAPON;
            if (sConfigMgr->GetBoolDefault("AutoLearn.DualSpec", false))
                OnLevelSpellMask += SPELL_MASK_DUAL_SPEC;

            if (sConfigMgr->GetBoolDefault("AutoLearn.Login.Spell", false))
                OnLoginSpellMask += OnLevelSpellMask;

            if (sConfigMgr->GetBoolDefault("AutoLearn.Create.Spell", false))
                OnCreateSpellMask += OnLevelSpellMask;
        }

        if (sConfigMgr->GetBoolDefault("AutoLearn.SpellProfession", false))
            OnSkillSpellMask += SPELL_MASK_PROFESSION;

        if (sConfigMgr->GetBoolDefault("AutoLearn.Login.Skill", false))
            OnLoginSpellMask += OnSkillSpellMask;

        if (sConfigMgr->GetBoolDefault("AutoLearn.Create.Skill", false))
            OnCreateSpellMask += OnSkillSpellMask;

        if (loadSpellMask != (OnLevelSpellMask | OnSkillSpellMask))
            LoadDataFromDataBase();
    }

    void LoadDataFromDataBase()
    {
        LearnSpellForClass.clear();
        uint8 spellMask = OnLevelSpellMask | OnSkillSpellMask;

        if (spellMask == 0)
            return;

        TC_LOG_INFO("server.loading", "Loading AutoLearn...");
        uint32 oldMSTime = getMSTime();

        QueryResult result = WorldDatabase.PQuery("SELECT SpellId, SpellMask, RequiredClassMask, RequiredRaceMask, RequiredLevel, RequiredSpellId, RequiredSkillId, RequiredSkillValue FROM `world_autolearn`");

        if (!result)
            return;

        uint16 count = 0;

        do
        {
            Field* fields = result->Fetch();

            LearnSpellForClassInfo Spell;

            Spell.SpellId               = fields[0].GetUInt32();
            Spell.SpellMask             = fields[1].GetUInt16();
            Spell.RequiredClassMask     = fields[2].GetUInt32();
            Spell.RequiredRaceMask      = fields[3].GetUInt32();
            Spell.RequiredLevel         = fields[4].GetUInt8();
            Spell.RequiredSpellId       = fields[5].GetUInt32();
            Spell.RequiredSkillId       = fields[6].GetUInt16();
            Spell.RequiredSkillValue    = fields[7].GetUInt16();

            if (!sSpellMgr->GetSpellInfo(Spell.SpellId))
            {
                TC_LOG_ERROR("sql.sql", "AutoLearn: Spell (ID: %u) non-existing", Spell.SpellId);
                continue;
            }

            // Skip spell
            if (!(Spell.SpellMask & spellMask))
                continue;

            if (Spell.RequiredClassMask != 0 && !(Spell.RequiredClassMask & CLASSMASK_ALL_PLAYABLE))
            {
                TC_LOG_ERROR("sql.sql", "AutoLearn: Spell (ID: %u) RequiredClassMask (Mask: %u) non-existing", Spell.SpellId, Spell.RequiredClassMask);
                continue;
            }

            if (Spell.RequiredRaceMask != 0 && !(Spell.RequiredRaceMask & RACEMASK_ALL_PLAYABLE))
            {
                TC_LOG_ERROR("sql.sql", "AutoLearn: Spell (ID: %u) RequiredRaceMask (Mask: %u) non-existing", Spell.SpellId, Spell.RequiredRaceMask);
                continue;
            }

            if (Spell.RequiredSpellId != 0 && !sSpellMgr->GetSpellInfo(Spell.RequiredSpellId))
            {
                TC_LOG_ERROR("sql.sql", "AutoLearn: Spell (ID: %u) RequiredSpellId (ID: %u) non-existing", Spell.SpellId, Spell.RequiredSpellId);
                continue;
            }

            LearnSpellForClass.push_back(Spell);
            ++count;
        }
        while (result->NextRow());

        TC_LOG_INFO("server.loading", ">> Loaded %u spells for AutoLearn in %u ms", count, GetMSTimeDiffToNow(oldMSTime));
    }
};

class Mod_AutoLearn_PlayerScript : public PlayerScript
{
public:
    Mod_AutoLearn_PlayerScript() : PlayerScript("Mod_AutoLearn_PlayerScript") { }

    // Called when a player's level changes (right before the level is applied)
    void OnLevelChanged(Player* Player, uint8 /*oldLevel*/)
    {
        if (!AutoLearnEnable)
            return;

        AutoLearnSpell(OnLevelSpellMask, Player);
    }

    // Called when a player logs in.
	void OnLogin(Player* player)
    {
        if (!AutoLearnEnable || !OnLoginSpellMask)
            return;

        AutoLearnSpell(OnLoginSpellMask, player);
    }

    // Called when a player is created.
    void OnCreate(Player* player)
    {
        if (!AutoLearnEnable || !OnCreateSpellMask)
            return;

        AutoLearnSpell(OnCreateSpellMask, player);
        player->SaveToDB();
    }

    // Called when a player skill update
    void OnPlayerSkillUpdate(Player* Player, uint16 SkillId, uint16 /*SkillValue*/, uint16 SkillNewValue)
    {
        if (!AutoLearnEnable)
            return;

        AutoLearnSpell(OnSkillSpellMask, Player, SkillId, SkillNewValue);
    }

    void AutoLearnSpell(uint8 SpellMask, Player* Player, uint16 SkillId = 0, uint16 SkillValue = 0)
    {
        if (SpellMask & SPELL_MASK_DUAL_SPEC)
        {
            learnDualSpec(Player);
            SpellMask -= SPELL_MASK_DUAL_SPEC;
        }

        if (SpellMask == 0) return;

        uint32  PlayerClassMask = Player->getClassMask();
        uint32  PlayerRaceMask  = Player->getRaceMask();
        uint8   PlayerLevel     = Player->getLevel();

        for (uint16 i = 0; i < LearnSpellForClass.size(); ++i)
        {
            LearnSpellForClassInfo &Spell = LearnSpellForClass[i];
            if (!(Spell.SpellMask & SpellMask)) continue;
            if (Spell.RequiredClassMask != 0 && !(Spell.RequiredClassMask & PlayerClassMask)) continue;
            if (Spell.RequiredRaceMask != 0 && !(Spell.RequiredRaceMask & PlayerRaceMask)) continue;
            if (Spell.RequiredLevel > PlayerLevel) continue;
            if (Spell.RequiredSkillId != SkillId) continue;
            if (Spell.RequiredSkillValue > SkillValue) continue;
            if (Player->HasSpell(Spell.SpellId)) continue;
            if (Spell.RequiredSpellId != 0 && !Player->HasSpell(Spell.RequiredSpellId)) continue;

            Player->LearnSpell(Spell.SpellId, false);
        }
    }

    void learnDualSpec(Player* Player)
    {
        if (Player->getLevel() < sWorld->getIntConfig(CONFIG_MIN_DUALSPEC_LEVEL)) return;

        if (Player->GetSpecsCount() != 1) return;

        Player->CastSpell(Player, 63680, true, NULL, NULL, Player->GetGUID());
        Player->CastSpell(Player, 63624, true, NULL, NULL, Player->GetGUID());
    }
};

void AddSC_Mod_AutoLearn()
{
    new Mod_AutoLearn_PlayerScript();
    new Mod_AutoLearn_WorldScript();
}

Im getting this message on VSStudio:

Error 1 error C4263: 'void Mod_AutoLearn_PlayerScript::OnLogin(Player *)' : member function does not override any base class virtual member function C:\Users\Demonid\Github\VortexCore\src\server\scripts\Custom\mod_autolearn.cpp 166 1 scripts
Error 2 error C4264: 'void PlayerScript::OnLogin(Player *,bool)' : no override available for virtual member function from base 'PlayerScript'; function is hidden C:\Users\Demonid\Github\VortexCore\src\server\scripts\Custom\mod_autolearn.cpp 232 1 scripts
Error 4 error LNK1120: 1 unresolved externals C:\Users\Demonid\Desktop\Trinitycore\Build\bin\MinSizeRel\worldserver.exe worldserver
Error 3 error LNK2019: unresolved external symbol "void __cdecl AddSC_Mod_AutoLearn(void)" (?AddSC_Mod_AutoLearn@@YAXXZ) referenced in function "void __cdecl AddCustomScripts(void)" (?AddCustomScripts@@YAXXZ) C:\Users\Demonid\Desktop\Trinitycore\Build\src\server\worldserver\game.lib(ScriptLoader.obj) worldserver
5 IntelliSense: identifier "sConfigMgr" is undefined c:\Users\Demonid\Github\VortexCore\src\server\scripts\Custom\mod_autolearn.cpp 38 27 scripts

Could somebody pls give it a check? Seems like they changed something on Void OnLogin, but i still dont understand it.
 
Rochet2

Rochet2

Moderator / Eluna Dev
I recommend using the override keyword to make sure the hooks override the virtual functions.
void OnLogin(Player* player)
should be
void OnLogin(Player* player, bool /*firstLogin*/)

You can see that easily from scriptmgr.h where the hook is declared. The error also suggest you to check that.
 
Status
Not open for further replies.
Top