[Trinity C++] Profession npc

Synth · Sep 24, 2013

Hello Emudevs,today i'm releasing an profession NPC gotten from Sdyess release some time ago, and it was updated by Jameyboor.So I decided to release it to you guys on Emudevs,it was released on a website by Ghostcrawler336.

Script info:
●This npc will allow you to learn up to two professions noting much about it.

SQL:

-- Professions NPC
INSERT INTO `creature_template` (`entry`, `difficulty_entry_1`, `difficulty_entry_2`, `difficulty_entry_3`, `KillCredit1`, `KillCredit2`, `modelid1`, `modelid2`, `modelid3`, `modelid4`, `name`, `subname`, `IconName`, `gossip_menu_id`, `minlevel`, `maxlevel`, `exp`, `faction_A`, `faction_H`, `npcflag`, `speed_walk`, `speed_run`, `scale`, `rank`, `mindmg`, `maxdmg`, `dmgschool`, `attackpower`, `dmg_multiplier`, `baseattacktime`, `rangeattacktime`, `unit_class`, `unit_flags`, `unit_flags2`, `dynamicflags`, `family`, `trainer_type`, `trainer_spell`, `trainer_class`, `trainer_race`, `minrangedmg`, `maxrangedmg`, `rangedattackpower`, `type`, `type_flags`, `lootid`, `pickpocketloot`, `skinloot`, `resistance1`, `resistance2`, `resistance3`, `resistance4`, `resistance5`, `resistance6`, `spell1`, `spell2`, `spell3`, `spell4`, `spell5`, `spell6`, `spell7`, `spell8`, `PetSpellDataId`, `VehicleId`, `mingold`, `maxgold`, `AIName`, `MovementType`, `InhabitType`, `HoverHeight`, `Health_mod`, `Mana_mod`, `Armor_mod`, `RacialLeader`, `questItem1`, `questItem2`, `questItem3`, `questItem4`, `questItem5`, `questItem6`, `movementId`, `RegenHealth`, `equipment_id`, `mechanic_immune_mask`, `flags_extra`, `ScriptName`, `WDBVerified`) VALUES (700014, 0, 0, 0, 0, 0, 24454, 0, 0, 0, 'Professions', 'Emudevs', NULL, 0, 80, 80, 0, 35, 35, 1, 1, 1.14286, 1.5, 0, 13, 17, 0, 42, 1, 1500, 0, 1, 512, 2048, 8, 0, 0, 0, 0, 0, 9, 13, 100, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, '', 0, 3, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 2, 'Professions_NPC', 12340);

Script:
Professions NPC - C++ - EmuDevs Paste

If you find any bug or errors once you compile feel free to ask me!
Thank you!
Best regards,
Synth !

Jameyboor · Sep 24, 2013

Thanks for sharing :smile:

Synth · Sep 24, 2013

Jameyboor said:
Thanks for sharing :smile:

No problem bro :tongue:

Tommy · Sep 24, 2013

Thanks for sharing! <3

Synth · Sep 24, 2013

Tommy said:
Thanks for sharing! <3

No problem :smile:

bromia · Dec 17, 2013

Compile error with fresh trinitycore

Error 1 error C2039: 'outError' : is not a member of 'Log' C:\Source\TrinityCore2\src\server\scripts\Custom\professions_npc.cpp 89 1 scripts
Error 2 error C2065: 'LOG_FILTER_PLAYER_SKILLS' : undeclared identifier C:\Source\TrinityCore2\src\server\scripts\Custom\professions_npc.cpp 89 1 scripts

Tommy · Dec 17, 2013

Fixed: http://paste.emudevs.com/?paste=21

bromia · Dec 19, 2013

Thx, working

Edit: Npc need SQL update!

I fix, but little custom from stat's. why? I create new row from creature_template, and write new stat... (HP, Mana, Armor) Any stat's copy from original = untouched!

Fix:

Code:

INSERT INTO `world`.`creature_template` (`entry`, `difficulty_entry_1`, `difficulty_entry_2`, `difficulty_entry_3`, `KillCredit1`, `KillCredit2`, `modelid1`, `modelid2`, `modelid3`, `modelid4`, `name`, `subname`, `IconName`, `gossip_menu_id`, `minlevel`, `maxlevel`, `exp`, `faction_A`, `faction_H`, `npcflag`, `speed_walk`, `speed_run`, `scale`, `rank`, `mindmg`, `maxdmg`, `dmgschool`, `attackpower`, `dmg_multiplier`, `baseattacktime`, `rangeattacktime`, `unit_class`, `unit_flags`, `unit_flags2`, `dynamicflags`, `family`, `trainer_type`, `trainer_spell`, `trainer_class`, `trainer_race`, `minrangedmg`, `maxrangedmg`, `rangedattackpower`, `type`, `type_flags`, `lootid`, `pickpocketloot`, `skinloot`, `resistance1`, `resistance2`, `resistance3`, `resistance4`, `resistance5`, `resistance6`, `spell1`, `spell2`, `spell3`, `spell4`, `spell5`, `spell6`, `spell7`, `spell8`, `PetSpellDataId`, `VehicleId`, `mingold`, `maxgold`, `AIName`, `MovementType`, `InhabitType`, `HoverHeight`, `Health_mod`, `Mana_mod`, `Armor_mod`, `RacialLeader`, `questItem1`, `questItem2`, `questItem3`, `questItem4`, `questItem5`, `questItem6`, `movementId`, `RegenHealth`, `mechanic_immune_mask`, `flags_extra`, `ScriptName`, `WDBVerified`) VALUES ('700014', '0', '0', '0', '0', '0', '24454', '0', '0', '0', 'Professions', 'Emudevs', '', '0', '80', '80', '0', '35', '35', '1', '1', '1', '1', '3', '1000', '20000', '0', '0', '1', '2000', '2000', '1', '512', '2048', '8', '0', '0', '0', '0', '0', '0', '0', '0', '13', '100', '7', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '', '1', '1', '1', '3', '3', '3', '0', '0', '0', '0', '0', '0', '0', '0', '1', '0', '2', 'Professions_NPC', '12340');

Synth · Dec 21, 2013

bromia said:

Thx, working

Edit: Npc need SQL update!

I fix, but little custom from stat's. why? I create new row from creature_template, and write new stat... (HP, Mana, Armor) Any stat's copy from original = untouched!

Fix:

Code:

INSERT INTO `world`.`creature_template` (`entry`, `difficulty_entry_1`, `difficulty_entry_2`, `difficulty_entry_3`, `KillCredit1`, `KillCredit2`, `modelid1`, `modelid2`, `modelid3`, `modelid4`, `name`, `subname`, `IconName`, `gossip_menu_id`, `minlevel`, `maxlevel`, `exp`, `faction_A`, `faction_H`, `npcflag`, `speed_walk`, `speed_run`, `scale`, `rank`, `mindmg`, `maxdmg`, `dmgschool`, `attackpower`, `dmg_multiplier`, `baseattacktime`, `rangeattacktime`, `unit_class`, `unit_flags`, `unit_flags2`, `dynamicflags`, `family`, `trainer_type`, `trainer_spell`, `trainer_class`, `trainer_race`, `minrangedmg`, `maxrangedmg`, `rangedattackpower`, `type`, `type_flags`, `lootid`, `pickpocketloot`, `skinloot`, `resistance1`, `resistance2`, `resistance3`, `resistance4`, `resistance5`, `resistance6`, `spell1`, `spell2`, `spell3`, `spell4`, `spell5`, `spell6`, `spell7`, `spell8`, `PetSpellDataId`, `VehicleId`, `mingold`, `maxgold`, `AIName`, `MovementType`, `InhabitType`, `HoverHeight`, `Health_mod`, `Mana_mod`, `Armor_mod`, `RacialLeader`, `questItem1`, `questItem2`, `questItem3`, `questItem4`, `questItem5`, `questItem6`, `movementId`, `RegenHealth`, `mechanic_immune_mask`, `flags_extra`, `ScriptName`, `WDBVerified`) VALUES ('700014', '0', '0', '0', '0', '0', '24454', '0', '0', '0', 'Professions', 'Emudevs', '', '0', '80', '80', '0', '35', '35', '1', '1', '1', '1', '3', '1000', '20000', '0', '0', '1', '2000', '2000', '1', '512', '2048', '8', '0', '0', '0', '0', '0', '0', '0', '0', '13', '100', '7', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '', '1', '1', '1', '3', '3', '3', '0', '0', '0', '0', '0', '0', '0', '0', '1', '0', '2', 'Professions_NPC', '12340');

Thank you :smile:

- - - Updated - - -

bromia said:
Thx, working

Edit: Npc need SQL update!

I fix, but little custom from stat's. why? I create new row from creature_template, and write new stat... (HP, Mana, Armor) Any stat's copy from original = untouched!

Fix:

Thank you :smile:

Demonid · Dec 24, 2013

This Script needs an Update since Trinitycore Commit: https://github.com/TrinityCore/TrinityCore/commit/107af528536980380c887379b56f6351a9781a2f

This are the errors:

http://puu.sh/5X24W.png

Demonid · Dec 26, 2013

To fix the MonsterWhisper error change GetGUID to ToPlayer

For example:

_creature->MonsterWhisper(text, pPlayer->GetGUID());

to

_creature->MonsterWhisper(text, pPlayer->ToPlayer());

jeremymeile · Jan 4, 2014

Very nice but...

if you already learned first aid or cooking you cannot learn it from the npc... is there a way to delete these before the npc add you the new profession?

Tommy · Jan 4, 2014

Demonid said:
To fix the MonsterWhisper error change GetGUID to ToPlayer

For example:

_creature->MonsterWhisper(text, pPlayer->GetGUID());

to

_creature->MonsterWhisper(text, pPlayer->ToPlayer());

Why are you calling 'ToPlayer()' when 'pPlayer' is Player*? It should be:

Code:

_creature->MonsterWhisper(text, pPlayer);

jeremymeile said:
Very nice but...

if you already learned first aid or cooking you cannot learn it from the npc... is there a way to delete these before the npc add you the new profession?

What do you mean? Those are secondary skills, why would you want to remove them?

I'll redo the script, it is poorly coded (or updated), outdated and ignores a lot of easy functions to call for some of this for simplification..

Updated: http://paste.emudevs.com/?paste=43

Blazeqts · Jan 25, 2014

Tommy, i get compile errors using ur updated script.

http://pastebin.com/hT0qHpBd

any solution?

Tommy · Jan 25, 2014

On line 208, it should be 'return false', not 'return', fixed:

http://paste.emudevs.com/?paste=88

Blazeqts · Jan 25, 2014

Tommy, can you make it so the amount of skill you get from taking a profession is only 150, and not 450?

Would appreciate it!

sandyqyh · Feb 26, 2014

Very cool!Thank you !
There is a suggestion:
If you learn,you should hide this option or mark it.

[Trinity C++] Profession npc

Synth

Exalted Member

Jameyboor

Retired Staff

Synth

Exalted Member

Tommy

Founder

Synth

Exalted Member

bromia

Enthusiast

Tommy

Founder

bromia

Enthusiast

Synth

Exalted Member

Demonid

Enthusiast

Demonid

Enthusiast

jeremymeile

Enthusiast

Tommy

Founder

Blazeqts

Enthusiast

Tommy

Founder

Blazeqts

Enthusiast

sandyqyh

Enthusiast