[WotLK] [C++] Arena System - UPDATED -With World Config

[Wolord]

Hi EmuDevs, I had also updated the arena_pvp_system.cpp from U-wow scripts with config.​

#include "ScriptPCH.h"

class arena_system : public PlayerScript
{
public:
	arena_system() : PlayerScript("arena_system") {}

	void OnPVPKill(Player* killer, Player* killed)
	{
		if (killer->GetMap()->IsBattleArena())
		{
		                ChatHandler(killer->GetSession()).PSendSysMessage("You just killed |cffFF0000%s|r in arena and stole " + (killed->getGender() == MALE ? "his" : "her") + " soul.", killed->GetName());
				killer->AddItem(sWorld->getIntConfig(CONFIG_ARENA_SOUL_ID), sWorld->getIntConfig(CONFIG_ARENA_SOUL_COUNT));

		}
	}
};

void AddSC_arena_system()
{
	new arena_system;
}

TESTED ON LATEST TrinityCore.​

Remember to add : sWorld->getIntConfig(CONFIG_ARENA_SOUL_ID) and sWorld->getIntConfig(CONFIG_ARENA_SOUL_COUNT) to your world.cpp and world.h.

Special Thanks to : Parranoia

 

[Crow]

I dont understand exactly what this is? Perhaps you should clarify more.

 

[Wolord]

I dont understand exactly what this is? Perhaps you should clarify more.

It is a script whenever you kill somebody in an arena match will give you a reward for that.:wink2:

 

[Parranoia]

Could have simplified it to something like this

ChatHandler(killer->GetSession()).PSendSysMessage("You just killed |cffFF0000%s|r in arena and stole " + (killed->getGender() == MALE ? "his" : "her") + " soul.", killed->GetName());

 

[Wolord]

Could have simplified it to something like this

ChatHandler(killer->GetSession()).PSendSysMessage("You just killed |cffFF0000%s|r in arena and stole " + (killed->getGender() == MALE ? "his" : "her") + " soul.", killed->GetName());

Thanks. i did it.:laughing:

 

[Jpp]

Script will only work if the player's gender is male.

 

[Rochet2]

Script will only work if the player's gender is male.

Hmm, why would that be?

Btw killed->GetName() needs to be converted to const char* with killed->GetName().c_str()

 

[Mookz]

Thanks, this could be useful.

 

[Jpp]

Hmm, why would that be?

Btw killed->GetName() needs to be converted to const char* with killed->GetName().c_str()

if (killed->getGender() == MALE)
{
}

 

[Rochet2]

if (killed->getGender() == MALE)
{
}

I see no such thing though.. only
killed->getGender() == MALE ? "his" : "her"

 

[Jpp]

I see no such thing though.. only
killed->getGender() == MALE ? "his" : "her"

Post has been edited. You can also see it in the indentation.

 

[callmephil]

& also you can overpass writing config in world.cpp/h by using directly the fonction inside the custom file (Better for simple custom script) check this : http://emudevs.com/showthread.php/2811-Item-bonus-rate

you could use something like that :

 if(sConfigMgr->GetIntDefault("XXX.XXX.XXX", VALUE)))

 

[Crow]

It is a script whenever you kill somebody in an arena match will give you a reward for that.:wink2:

so basically it's just another kill token script.

/shrug, we dont judge on emudevs but I really gotta admit, it's not really a new idea. A good suggestion is to just do automatic arena points by adding it or writing something that isnt as cheesy imo as "stealing souls" unless you made a specific arena/necromancer zone type thing going.

whatever, it's a decent enough release, good job. Just feels kinda bland is all imo

 

[Clastor]

I get an error