[SOLVED] Adding to core

[yvoms]

So i was curious, since one of my friends told me Eluna is a massive addition to my server,
I wanted to add it, I cloned the stuff from git, and i have it on my desktop.
As of now i want to add it to my current core/build, or do i need to do a recompile?
Anyways i do need a little bit of assistance doing this.
I was hoping someone could help me out.

 

[Rochet2]

Try reading this:
https://github.com/ElunaLuaEngine/Eluna/blob/master/docs/MERGING.md

Do note that if you do want to merge Eluna to some other core or variation, you are on your own.
(even though it is pretty easy in itself and similar to merging with TC/mangos/cmangos)


The idea is that Eluna requires a set of core modifications which are made already to mangos, cmangos and TrinityCore in our repo links on Eluna readme.
You should be able to get for example TC and just merge our repo with it to get the Eluna required changes to your core.
However merging also updates your core if you have older than what we have or if you have newer you might get merge or compile errors etc.
You should be able to fix those on your own.

Otherwise the normal install is just to clone our repo and keep pulling updates from that.
This way you cant be on older or newer than what we are and you should not get merge conflicts nor compile errors.

 

[Tommy]

So i was curious, since one of my friends told me Eluna is a massive addition to my server,
I wanted to add it, I cloned the stuff from git, and i have it on my desktop.
As of now i want to add it to my current core/build, or do i need to do a recompile?
Anyways i do need a little bit of assistance doing this.
I was hoping someone could help me out.

Read Merging. You need to make sure your current emulator source is consistent with Eluna's TC version. If it isn't, then you will have issues merging. There's more to in than just adding the 'LuaEngine' folder. Eluna implementation edits cmake and source files. We also have some custom edits to certain methods, etc to work with Eluna and possibly cross-compatible with other emulators Eluna supports.

I honestly recommend people download Eluna's TC (or mangos) WotLK (or other expansion) source(s) and make a server off of that since it is a wise choice, because in the future if you download just the TC source and you're wanting Eluna, it is a chore to merge. As I mentioned, it is best to just use our sources if you or anyone wants to use Eluna.

That being said, I don't have any .patch or .diff files to help you merge quicker (does not change the fact that there might not be conflicts if your source isn't consistent with Eluna's TC WotLK source).

or do i need to do a recompile?

Not sure why you think you need to recompile when cloning the source is just cloning it, it won't magically implement itself.

 

[yvoms]

I accidently nailed it, so ill start clean with eluna

 

[yvoms]

Resolved, can close it