eluna setup

[renatokeys]

Hi , how i can download trinitycore from trinitycore REPO and add eluna ? if i add LuaEngine to src and change cmake will work to compile ?

 

[Hyperion]

Eluna already comes with the TC source in it's repository

 

[renatokeys]

but tc repo have new fixes etc... how i can merge actually eluna repo with new fixes in trinitycore repo ?

 

[Hyperion]

but tc repo have new fixes etc... how i can merge actually eluna repo with new fixes in trinitycore repo ?

Are you sure they are fixes and not just pointless updates? Usually Tommy updates the Eluna repo when there is something to actually update

 

[renatokeys]

Are updates commits , i can use eluna repo and apply commitis fixes ? how i do this without mannualy 1 by 1 ?

 

[Tommy]

if i add LuaEngine to src and change cmake will work to compile ?

That should be obvious. Depending on what they updated, it could affect it. If they change a function's name for example, Eluna will most likely error because it will need to be updated with the newest changes. Normally all of the merged errors (if there are any) are obvious to fix for someone with no knowledge of coding.

but tc repo have new fixes etc... how i can merge actually eluna repo with new fixes in trinitycore repo ?

They aren't ALWAYS updates that require a 'needed' merge. Eluna will be merged when we merge it with TC. If you don't want to wait, pull up the git console in the ElunaTCWotLK source and do:

git pull https://github.com/TrinityCore/TrinityCore

Are updates commits , i can use eluna repo and apply commitis fixes ? how i do this without mannualy 1 by 1 ?

Why don't you appropriately reply without asking the same question? You've asked it a million times already and haven't really answered Faded's questions at all.


We don't do merges too often because we don't want to merge every second of everyday when there's a new commit from TC. Most of their updates aren't worth pulling. We do, however, pull when there's an important update. Be careful though. Their updates they push aren't tested.

 

[renatokeys]

Sorry , i understand , thanks.

 

[Rochet2]

You can merge Eluna with TC and TC with eluna.
Both work the same way.

See here:
https://github.com/ElunaLuaEngine/Eluna/blob/master/docs/MERGING.md
This guides how to merge Eluna to a TC source.

ps. It is supposed to be a general guide that works with any mangos and TC source.
Note that mangos VS solutions may mess up.

 

[renatokeys]

thx so much Rochet2 . :RpS_thumbsup: