Kreatyve's Suggestions

[Kreatyve]

First, let me say what a great project this is!
I absolutely find this the most useful release in *******/WoW Emulation history.
I do would like somewhere to post suggestions, so I am making this thread to post my suggestions (No clue where else to go).
I don't know the Trinity core files very well, I am also a beginner at C++.

Methods I'd like to see:
local PositionZ = FindZFromXY(PositionX, PositionY); -- Global.
-- Finds the ground level (Position Z) for the given X and Y value.
-- Useful for: Anti-Cheats, missing Z parameters in other methods.
-- May require vmaps, if it doesn't great! -- Added Z = GetHeight(Map, X, Y[, Phase]); Thank you Foereaper.

This is all for now.

Thanks,
Kreatyve.

 

[DndTheTroll]

Great idea. You've my support

 

[Rochet2]

local PositionZ = FindZFromXY(PositionX, PositionY); -- Global.

This already exists. See unit:GetHeight(X, Y)
Its not global though.

 

[Kreatyve]

I mean the ground's height not the unit's height. (To detect if a Unit is levitating.)

if(unit:GetHeight(unit:GetX(), unit:GetY()) ~= GetZFromXY(unit:GetX(), unit:GetY())) then
-- Unit is in the air, not on the ground.
end

 

[Tommy]

Interesting. That might be a nice global function to make.

 

[Rochet2]

I mean the ground's height not the unit's height. (To detect if a Unit is levitating.)

if(unit:GetHeight(unit:GetX(), unit:GetY()) ~= GetZFromXY(unit:GetX(), unit:GetY())) then
-- Unit is in the air, not on the ground.
end

Get height is what you are looking for.
Get z would return the height of the unit. Note that getheight requires x And y coords
.....
it could be made global though. Then it would require map and instanceid.

http://github.com/ElunaLuaEngine/Source/issues/31

 

[Kreatyve]

Yes that is true, does need map and instanceid parameter.

So Z = GetHeight(Map, X, Y, InstanceID);

=]

 

[Rochet2]

Atm it gets them from the unit.

 

[Foereaper]

Added GetHeight(map, x, y[, phase]) global method.

https://github.com/ElunaLuaEngine/Source/commit/89f880d94de81671fc8376195526415ee070dce2

 

[Kreatyve]

Why phase?

And thank you so much!

 

[Tommy]

Why phase?

And thank you so much!

It is an argument in a function in C++.

 

[Foereaper]

Why phase?

And thank you so much!

Phase is optional, but I added it to avoid using magic numbers. It'll be phase 1 by default if you don't use the argument.