[SOLVED] Update Arena Spectate - PAID

katos · Mar 13, 2015

Hi all,

After a plethora of bad developers leaving and not replying, I am after a developer who is able to update Arena Spectator for Revision 57 Trinitycore (without Eluna). We have a script (with the applied diff) currently, but sadly the script appears not to work with rev 57. We are willing to pay for a high quality script.

Based on the past experience with developers, we would prefer to pay when the script is confirmed working, but we are willing to pay half upfront.

The errors we're receiving so far:

Code:

Error	1	error C2628: 'arena_spectator_commands::npc_arena_spectator' followed by 'bool' is illegal (did you forget a ';'?)	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	505	1	scripts
Error	2	error C2065: 'target_guid' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	45	1	scripts
Error	3	error C2065: 'target_guid' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	48	1	scripts
Error	4	error C2065: 'target_guid' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	189	1	scripts
Error	5	error C3646: 'OVERRIDE' : unknown override specifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	265	1	scripts
Error	6	error C2270: 'GetCommands' : modifiers not allowed on nonmember functions	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	265	1	scripts
Error	7	error C2601: 'GetCommands' : local function definitions are illegal	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	265	1	scripts
Error	8	error C2143: syntax error : missing ';' before '='	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	336	1	scripts
Error	9	error C2664: 'ObjectGuid::ObjectGuid(const ObjectGuid &)' : cannot convert argument 1 from 'int' to 'const ObjectGuid &'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	396	1	scripts
Error	10	error C2039: 'GetArenaMatchmakerRatingByIndex' : is not a member of 'Battleground'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	428	1	scripts
Error	11	error C2039: 'GetArenaMatchmakerRatingByIndex' : is not a member of 'Battleground'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	438	1	scripts
Error	12	error C2039: 'GetArenaMatchmakerRatingByIndex' : is not a member of 'Battleground'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	448	1	scripts
Error	13	error C2327: 'arena_spectator_commands::GamesOnPage' : is not a type name, static, or enumerator	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	459	1	scripts
Error	14	error C2065: 'GamesOnPage' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	459	1	scripts
Error	15	error C2327: 'arena_spectator_commands::GamesOnPage' : is not a type name, static, or enumerator	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	464	1	scripts
Error	16	error C2065: 'GamesOnPage' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	464	1	scripts
Error	17	error C2327: 'arena_spectator_commands::GamesOnPage' : is not a type name, static, or enumerator	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	470	1	scripts
Error	18	error C2065: 'GamesOnPage' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	470	1	scripts
Error	19	error C2327: 'arena_spectator_commands::GamesOnPage' : is not a type name, static, or enumerator	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	475	1	scripts
Error	20	error C2065: 'GamesOnPage' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	475	1	scripts
Error	21	error C2327: 'arena_spectator_commands::GamesOnPage' : is not a type name, static, or enumerator	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	481	1	scripts
Error	22	error C2065: 'GamesOnPage' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	481	1	scripts
Error	23	error C2327: 'arena_spectator_commands::GamesOnPage' : is not a type name, static, or enumerator	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	486	1	scripts
Error	24	error C2065: 'GamesOnPage' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	486	1	scripts
Error	25	error C2664: 'arena_spectator_commands::npc_arena_spectator::npc_arena_spectator(const arena_spectator_commands::npc_arena_spectator &)' : cannot convert argument 1 from 'bool' to 'const arena_spectator_commands::npc_arena_spectator &'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	508	1	scripts
Error	26	error C2664: 'arena_spectator_commands::npc_arena_spectator::npc_arena_spectator(const arena_spectator_commands::npc_arena_spectator &)' : cannot convert argument 1 from 'bool' to 'const arena_spectator_commands::npc_arena_spectator &'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	537	1	scripts
Error	27	error C2065: 'HandleSpectateCommand' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	268	1	scripts
Error	28	error C2065: 'HandleSpectateFromCommand' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	269	1	scripts
Error	29	error C2065: 'HandleSpectateResetCommand' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	270	1	scripts
Error	30	error C2065: 'HandleSpectateCancelCommand' : undeclared identifier	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	271	1	scripts
Error	31	error C2259: 'arena_spectator_commands' : cannot instantiate abstract class	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	542	1	scripts
Error	32	error C2061: syntax error : identifier 'npc_arena_spectator'	D:\katos\test core\core1\src\server\scripts\Custom\Arena_Spectator.cpp	543	1	scripts
Error	33	error LNK2019: unresolved external symbol "void __cdecl AddSC_arena_spectator_script(void)" (?AddSC_arena_spectator_script@@YAXXZ) referenced in function "void __cdecl AddCustomScripts(void)" (?AddCustomScripts@@YAXXZ)	D:\katos\test core\build\src\server\worldserver\game.lib(ScriptLoader.obj)	worldserver
Error	34	error LNK1120: 1 unresolved externals	D:\katos\test core\build\bin\Debug\worldserver.exe	worldserver

Hopefully somebody is able to help.
Thank you for looking at this thread, and many thanks in advance.
Regards,
Katos.

Neth · Mar 13, 2015

trinitycore rev 57 ? give me a link to the commit and the diff, i'll fix it for you for free

katos · Mar 13, 2015

Neth said:
trinitycore rev 57 ? give me a link to the commit and the diff, i'll fix it for you for free

That'd be fantastic.

.diff file:
https://gist.github.com/SymbolixDEV/9411639

Updated C++ Script:
http://pastebin.com/yzFi6qDx

Revision Commit:
https://github.com/TrinityCore/TrinityCore/commit/46863b3afacd4c36ec62ec2b1b2e288ea2b82547
(I think, please note I may be wrong here, but it's revision 57, no changes have been made to the structure of the C++ other than the revision 56-57 changes)

Hyperion · Mar 13, 2015

On a side note, don't offer to buy or pay for services, we will delete the thread.

Keeping it up since Neth offered to help you

katos · Mar 13, 2015

Faded said:
On a side note, don't offer to buy or pay for services, we will delete the thread.

Keeping it up since Neth offered to help you

Really, how come I can't offer to buy or pay for services? I presumed this would be fine? I do apologize.
Haven't been here in a while, fell out of touch with the rules, I'll refresh myself - my apologies.

Neth · Mar 13, 2015

I might be a little annoying but could you send the core with your change ? I have lots of works to do and I don't feel like dealing with that git apply crap :<
i'll just fix the reaming error directly

katos · Mar 14, 2015

I'm at work currently as got called in, but I'll shoot you the repo when I can.

Neth · Mar 14, 2015

just so we are on the same page, by changes I mean the core with the arena script you applied (the one where you get the error)

katos · Mar 14, 2015

Neth said:
just so we are on the same page, by changes I mean the core with the arena script you applied (the one where you get the error)

No worries, I will shoot this to Bitbucket for you now

renatokeys · Mar 15, 2015

i have a open thread here about this and the script only have 1 error, if u can fix this .

http://emudevs.com/showthread.php/4476-ArenaSpectator-update

but i believe to fix this have to remake objectguid system in script.

Neth · Mar 15, 2015

post the scripts, I am not a medium

katos · Mar 15, 2015

Have sent you the updated repo.
My apologies for the issues there.

katos · Mar 16, 2015

Still looking for help with this, thanks to [MENTION=39]Neth[/MENTION] for the offer, but sadly he was unable to help.
[MENTION=2]Faded[/MENTION], [MENTION=1]Tommy[/MENTION] or [MENTION=6]Rochet2[/MENTION] - I don't suppose there is any chance any of you would be able to do so? There is no worries if not.

Thank you for taking your time to look.
Regards,
Katos.

Rochet2 · Mar 16, 2015

I tested some things around a bit and ..
https://gist.github.com/Rochet2/07fe93c9569f91357fd0
made this.
I have no idea whether it will work or not since I never compiled it successfully or test it.

I applied the patch of yours, fixed the compile errors, few oddities, types, whitespace and few missing functions etc..
The command script part on all scripts everywhere never worked so I just fetched a working one somewhere.

There are still errors.
The commandscript requires the normal command RBAC changes and there is still one missing function: GetTopArenaTeamsByRank
Also something that really buggs me is that few lines of code were missing from the patch (see the gist above for two empty + lines)

Error list:

Code:

Error	1	error C2039: 'RBAC_PERM_COMMAND_SPECATE_VIEW' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	307
Error	2	error C2065: 'RBAC_PERM_COMMAND_SPECATE_VIEW' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	307
Error	3	error C2039: 'RBAC_PERM_COMMAND_SPECATE_RESET' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	308
Error	4	error C2065: 'RBAC_PERM_COMMAND_SPECATE_RESET' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	308
Error	5	error C2039: 'RBAC_PERM_COMMAND_SPECATE_LEAVE' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	309
Error	6	error C2065: 'RBAC_PERM_COMMAND_SPECATE_LEAVE' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	309
Error	7	error C2039: 'RBAC_PERM_COMMAND_SPECATE_PLAYER' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	310
Error	8	error C2065: 'RBAC_PERM_COMMAND_SPECATE_PLAYER' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	310
Error	9	error C2039: 'RBAC_PERM_COMMAND_SPECATE' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	316
Error	10	error C2065: 'RBAC_PERM_COMMAND_SPECATE' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	316
[COLOR="#FF0000"]Error	11	error C2039: 'GetTopArenaTeamByRank' : is not a member of 'BattlegroundMgr'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	670[/COLOR]
Error	12	error LNK1104: cannot open file '..\scripts\Debug\scripts.lib'	E:\Cores\TrinityCore\TEST\BUILD\src\server\worldserver\LINK

katos · Mar 16, 2015

Rochet2 said:

I tested some things around a bit and ..
https://gist.github.com/Rochet2/07fe93c9569f91357fd0
made this.
I have no idea whether it will work or not since I never compiled it successfully or test it.

I applied the patch of yours, fixed the compile errors, few oddities, types, whitespace and few missing functions etc..
The command script part on all scripts everywhere never worked so I just fetched a working one somewhere.

There are still errors.
The commandscript requires the normal command RBAC changes and there is still one missing function: GetTopArenaTeamsByRank
Also something that really buggs me is that few lines of code were missing from the patch (see the gist above for two empty + lines)

Error list:

Code:

Error	1	error C2039: 'RBAC_PERM_COMMAND_SPECATE_VIEW' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	307
Error	2	error C2065: 'RBAC_PERM_COMMAND_SPECATE_VIEW' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	307
Error	3	error C2039: 'RBAC_PERM_COMMAND_SPECATE_RESET' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	308
Error	4	error C2065: 'RBAC_PERM_COMMAND_SPECATE_RESET' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	308
Error	5	error C2039: 'RBAC_PERM_COMMAND_SPECATE_LEAVE' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	309
Error	6	error C2065: 'RBAC_PERM_COMMAND_SPECATE_LEAVE' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	309
Error	7	error C2039: 'RBAC_PERM_COMMAND_SPECATE_PLAYER' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	310
Error	8	error C2065: 'RBAC_PERM_COMMAND_SPECATE_PLAYER' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	310
Error	9	error C2039: 'RBAC_PERM_COMMAND_SPECATE' : is not a member of 'rbac'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	316
Error	10	error C2065: 'RBAC_PERM_COMMAND_SPECATE' : undeclared identifier	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	316
[COLOR="#FF0000"]Error	11	error C2039: 'GetTopArenaTeamByRank' : is not a member of 'BattlegroundMgr'	E:\Cores\TrinityCore\TEST\source\src\server\scripts\Custom\ArenaSpectator.cpp	670[/COLOR]
Error	12	error LNK1104: cannot open file '..\scripts\Debug\scripts.lib'	E:\Cores\TrinityCore\TEST\BUILD\src\server\worldserver\LINK

Fantastic, thanks for your help [MENTION=6]Rochet2[/MENTION]
I will compile the patch that you have made there and see what I can get, hopefully I can then go from there.
Would it help you at all if I uploaded the core to a private repo, added you to read/write permissions and shot this over to you at all?

Thanks for your swift reply and fantastic help.
Regards,
Katos

katos · Mar 16, 2015

there is still one missing function: GetTopArenaTeamsByRank

I can't find any reference to this is either .diff files at all, not a clue where this error is coming from! :O

katos · Mar 16, 2015

[MENTION=6]Rochet2[/MENTION] -

Just noticed that it seems that the .diff is missing the arenaspectate C++ script ?
Did you edit the pastebin one that I sent, or..?

Rochet2 · Mar 16, 2015

fixed

katos · Mar 16, 2015

Rochet2 said:
fixed

That's superb, thanks a lot Rochet - that error that you highlighted I can fix by simply removing the top arena team aspect. No idea why that was even added in the first place to be honest with you buddy!

I really appreciate your help [MENTION=6]Rochet2[/MENTION] - are you open to donations at all, for your help with this?

katos · Mar 19, 2015

I have now fully fixed the script, found the issue and resolved this.
I appreciate all of your help with this, it honestly means a huge amount. Thank you so much [MENTION=6]Rochet2[/MENTION] !

Thank you, thank you, thank you!

[SOLVED] Update Arena Spectate - PAID

Noble Member

BETA Tester

Noble Member

Founder

Noble Member

BETA Tester

Noble Member

BETA Tester

Noble Member

EOOQ

BETA Tester

Noble Member

Noble Member

Moderator / Eluna Dev

Noble Member

Noble Member

Noble Member

Moderator / Eluna Dev

Noble Member

Noble Member